Repository navigation
Fix build failure caused by lack of mmCif format short description - #447
Merged
Merged
Conversation
PR MDAnalysis/mdanalysis#4712 added an mmCIF reader and parser registered as CIF, CIF.GZ, MMCIF and MMCIF.GZ, which caused the userguide to fail with KeyError: 'CIF'. - add a CIF entry to DESCRIPTIONS - add `.upper` to format dictionary key selection to avoid having to define entries for cif.gz, mmcif and mmcif.gz
Member
|
orbeckst
approved these changes
Nov 15, 2026
orbeckst
left a comment
Member
There was a problem hiding this comment.
Thanks @jpkrowe . Sorry for the lack of review...
I am going to merge even though we don't have a full format page description. That can be something for another day.
(There are various CI issues but I am just going to merge this blind, given that the existing failures are not due to this PR and that it fixes the major issue with the build_docs workflow.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR MDAnalysis/mdanalysis#4712 added an mmCIF reader and parser registered as CIF, CIF.GZ, MMCIF and MMCIF.GZ, which causes the userguide to fail with KeyError: 'CIF'.
This partially fixes #441 as it doesn't add a full rst file for the format.
.upperto format dictionary key selection to avoid having to define entries for cif.gz, mmcif and mmcif.gz📚 Documentation preview 📚: https://mdanalysisuserguide--447.org.readthedocs.build/en/447/