Repository navigation
fix(css): resolve Sonar maintainability findings - #379
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 196 196
Branches 52 52
=========================================
Hits 196 196
Continue to review full report in Codecov by Harness.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Remove
!importantfrom the Crowdin themes and shared styles while preserving the intended colors and layout. Scope the Crowdin selectors to override its dynamically injected styles, clear conflicting inline Dockle positioning, and use Bootstrap's--bs-dark-rgbvariable to preserve the dark background in either stylesheet order.Restrict the image zoom transition to
transformand enable it only when the user has no reduced-motion preference. Keep the same hover state without animation for users who request reduced motion.Screenshot
Issues Fixed or Closed
css:S9423findings (!important) and onecss:S9449finding (transition scope) inLizardByte_shared-web.css:S9440for the zoom transition's reduced-motion behavior.9de38abf9824ba4c0004ffe7d167d081064fd92b.Roadmap Issues
Testing
npm test: all 56 tests passed with 100% statement, branch, function, and line coverage; ESLint passed.npm run build: passed with dependencies installed from the lockfile usingnpm ci --ignore-scripts.git diff --checkpassed. GitHub CI build, Common Lint, CodeQL, and Sonar checks passed.Type of Change
Checklist
AI Usage
See our AI usage policy.
Codex investigated the Sonar findings, implemented the fixes and regression-test updates, and ran local and browser validation.