Skip to content

fix(windows): preserve extended media key translation - #218

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-windows-extended-key-remapping
Nov 3, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-windows-extended-key-remapping

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Windows volume, media, browser, and application-launch keys can be translated into ordinary keys when their E0 extended-key prefix is lost. For example, volume down/up share scan codes with C/B.

For keys outside the existing navigation and modifier cases, query MapVirtualKeyW(..., MAPVK_VK_TO_VSC_EX) for the E0 prefix. This preserves the intended key in both SendInput and HID keyboard translation while keeping E1 Pause handling distinct.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Built test_libvirtualhid with MSYS2/UCRT64 and warnings treated as errors.
  • cmake-build-sunshine-4981/tests/test_libvirtualhid.exe --gtest_filter=WindowsBackendTest.*: all 16 tests passed.
  • Added regressions covering 18 media/browser/launch keys, normalized and native scan codes, press/release, volume HID reports, HID-to-SendInput fallback, and ordinary/E1 keys. The SendInput regression fails against the original implementation.
  • GCC coverage confirms the changed return statement is exercised and both paths through the extended-key helper execute.
  • clang-format --dry-run --Werror and git diff --check passed.

Installed-driver and end-to-end Moonlight validation were not run.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

This pull request was generated by Codex (GPT-6; thinking level not exposed in this session).

Copy link
Copy Markdown
Member Author

This pull request was generated by Codex (GPT-6; thinking level not exposed in this session).

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.66%. Comparing base (bf32e97) to head (a09c6a7).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   73.64%   73.66%   +0.01%     
==========================================
  Files          44       44              
  Lines       10705    10705              
  Branches     3651     3651              
==========================================
+ Hits         7884     7886       +2     
+ Misses       2182     2161      -21     
- Partials      639      658      +19     
Flag Coverage Δ
FreeBSD 53.99% <ø> (ø)
Linux-Clang 68.59% <ø> (ø)
Linux-GCC 80.55% <ø> (ø)
PowerShell 75.60% <ø> (ø)
Windows-MSVC 74.28% <100.00%> (+0.01%) ⬆️
Windows-MinGW-UCRT64 66.22% <100.00%> (+0.25%) ⬆️
macOS 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/windows_backend.cpp 83.89% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf32e97...a09c6a7. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 9f4cac3 into master Nov 3, 2026
36 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-windows-extended-key-remapping branch November 3, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant