[neroshooter]

Description

Installing from a DMG downloaded with Safari or Chrome fails at the end of Install libvirtualhid.command:

Bootstrap failed: 5: Input/output error

The apps are copied to /Applications, but the broker service never starts. Files on a mounted disk image inherit the image's com.apple.quarantine attribute. install and ditto keep it, so /Library/LaunchDaemons/dev.lizardbyte.app.libvirtualhid.plist ends up quarantined and launchctl bootstrap system rejects it.

This PR removes com.apple.quarantine (with xattr -dr) from everything the installer copies, before launchctl bootstrap:

• VirtualHIDBroker.app and VirtualHIDControl.app, right after ditto and before the signature checks;
• the LaunchDaemon plist;
• the installed /usr/local headers, static library, license tool, CMake package, and license texts, when present.

The installer already checks the bundled apps with codesign --verify --deep --strict before and after copying them, and the DMG itself is notarized and stapled, so dropping the download marker does not skip any signature check.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Manual validation on macOS 27.0.1 (Apple Silicon), using the current release DMG (libvirtualhid-macOS-universal.dmg, SHA-256 6ebe73f6…236a871):

• Reproduced: after a Safari download, the installer failed with Bootstrap failed: 5: Input/output error. xattr -l showed com.apple.quarantine on the installed plist and on both apps, and launchctl print system/dev.lizardbyte.app.libvirtualhid reported the service as missing.
• Confirmed the cause: after a full uninstall, I downloaded the same DMG again with Chrome, removed its quarantine attribute before mounting, and ran the unmodified installer. Bootstrap succeeded and launchctl print reported state = running.
• Script checks: bash -n scripts/macos/install.command passes. xattr -dr com.apple.quarantine removes the attribute from a bundle and exits 0 on files and directories that do not have it, so the script stays compatible with set -e for DMGs opened without quarantine.

Not run: I could not build a signed DMG containing this change (that needs the Developer ID identity and the virtual HID provisioning profile), so the patched installer has not been tested end to end from a quarantined DMG. No automated test was added because install.command requires sudo, launchctl, and a mounted signed image, and the repository has no harness for it.

Type of Change

• feat: New feature (non-breaking change which adds functionality)
• fix: Bug fix (non-breaking change which fixes an issue)
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
• refactor: Code change that neither fixes a bug nor adds a feature
• perf: Code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit
• BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

• Code follows the style guidelines of this project
• Code has been self-reviewed
• Code has been commented, particularly in hard-to-understand areas
• Code docstring/documentation-blocks for new or existing methods/components have been added or updated
• Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

• AI tools were used while preparing this PR

Claude Code helped diagnose the failed install, write the fix, and draft this description. I reproduced the failure and confirmed the workaround on my own Mac.

Generated with Claude Code (Claude Opus 5.5, low thinking level).

🤖 Generated with Claude Code

[CLAassistant]

All committers have signed the CLA.

[ReenigneArcher]

The quarantine cleanup passed local macOS validation. Please add the required regression coverage described in the inline comment; the included fixture was tested against both the current PR head and target branch.

Verified: bash -n, diff whitespace checks, native recursive/idempotent quarantine removal with unrelated attributes retained, and four sandboxed installer cases (quarantined/clean × optional payload present/absent). The target branch reproduces quarantine remaining at bootstrap; this head passes all four cases. No installed service was modified.

Validation limits: a signed quarantined DMG was not installed end to end. GitHub Actions workflows await maintainer approval. The GH-Pages Read the Docs status reports failure, but its logs were inaccessible, so I cannot attribute that failure to this patch. The head is mergeable into current master.

_{Review completed by Codex | Model: gpt-6.1-sol | Thinking: xhigh}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.61%. Comparing base (dd0ff88) to head (fa44284).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   73.64%   73.61%   -0.04%     
==========================================
  Files          44       44              
  Lines       10705    10705              
  Branches     3651     3651              
==========================================
- Hits         7884     7880       -4     
- Misses       2161     2220      +59     
+ Partials      660      605      -55     

Flag	Coverage Δ
FreeBSD	53.99% <ø> (ø)
Linux-Clang	68.59% <ø> (ø)
Linux-GCC	80.55% <ø> (ø)
PowerShell	75.60% <ø> (ø)
Windows-MSVC	74.19% <ø> (-0.10%)	⬇️
Windows-MinGW-UCRT64	66.15% <ø> (+0.23%)	⬆️
macOS	50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 10 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0ff88...fa44284. Read the comment docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud