Repository navigation
refactor: remove placeholder display importance overrides - #360
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1052 1052
=========================================
Hits 1052 1052 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Remove the three
css:S9423findings in the character, game, and platform detail templates. Each image placeholder now uses a hidden outer container and a flex child for centering, so Bootstrap'sd-flexutility no longer competes with the inline visibility declaration. Existing JavaScript reveal behavior, placeholder heights, and icons are preserved.Screenshot
Issues Fixed or Closed
SonarQube Cloud project
LizardByte_GameDB, rulecss:S9423:AaFWJZVUuaivhOi5kp8vAaFWJZXBuaivhOi5kp8xAaFWJZW-uaivhOi5kp8wRoadmap Issues
Testing
node node_modules/jest/bin/jest.js --coverage --runInBand --roots tests gh-pages-template/assets/js: 6 suites and 205 tests passed; 100% statements, branches, functions, and lines.npm run lint: passed.git diff --check: passed.No JavaScript behavior changed, so no persistent tests were added for this markup refactor. Hosted validation for commit
b08322595a3ecd9b9d4b58d85668d4864b1e8160: CI tests, Common Lint, CodeQL, and Codecov passed. Sonar reanalyzed PR #360 with zero open findings and a passing quality gate. Jekyll and Read the Docs builds are still running. The three default-branch findings remain until the change is merged and master is reanalyzed.Type of Change
Checklist
AI Usage
See our AI usage policy.