Skip to content

refactor: remove placeholder display importance overrides - #360

Merged
ReenigneArcher merged 1 commit into
masterfrom
codex/fix-sonar-placeholder-styles
Oct 30, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
codex/fix-sonar-placeholder-styles

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Description

Remove the three css:S9423 findings in the character, game, and platform detail templates. Each image placeholder now uses a hidden outer container and a flex child for centering, so Bootstrap's d-flex utility no longer competes with the inline visibility declaration. Existing JavaScript reveal behavior, placeholder heights, and icons are preserved.

Screenshot

Issues Fixed or Closed

SonarQube Cloud project LizardByte_GameDB, rule css:S9423:

  • Characters: AaFWJZVUuaivhOi5kp8v
  • Games: AaFWJZXBuaivhOi5kp8x
  • Platforms: AaFWJZW-uaivhOi5kp8w

Roadmap Issues

Testing

  • node node_modules/jest/bin/jest.js --coverage --runInBand --roots tests gh-pages-template/assets/js: 6 suites and 205 tests passed; 100% statements, branches, functions, and lines.
  • npm run lint: passed.
  • git diff --check: passed.
  • A one-off jsdom check loaded the actual three HTML templates and their existing renderers with Bootstrap's display/alignment utility declarations. All six image-present/image-missing cases passed: placeholders start hidden, remain hidden when an image exists, and reveal centered flex content at the original height when an image is absent.

No JavaScript behavior changed, so no persistent tests were added for this markup refactor. Hosted validation for commit b08322595a3ecd9b9d4b58d85668d4864b1e8160: CI tests, Common Lint, CodeQL, and Codecov passed. Sonar reanalyzed PR #360 with zero open findings and a passing quality gate. Jekyll and Read the Docs builds are still running. The three default-branch findings remain until the change is merged and master is reanalyzed.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7a8001b) to head (b083225).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1052      1052           
=========================================
  Hits          1052      1052           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8001b...b083225. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher
ReenigneArcher merged commit 35e4940 into master Oct 30, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the codex/fix-sonar-placeholder-styles branch October 30, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant