Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Hancom Office word processor formats (
.hwp,.hwpx) to the output extension allowlist, so files written to/mnt/datawith these extensions are returned to the caller.HWP/HWPX is the standard document format for Korean government and many Korean organizations. Code can already create these files in the sandbox (for example with
@rhwp/core), butisSupportedOutputFilenamedrops them, so the user never receives the document.Evidence
New test in
api/src/walker.test.ts:Expected [UPPER.HWP, report.hwp, report.hwpx], Received []bun test src/walker.test.ts→ 70 pass, 0 fail.Full
bun testinapi/(bun 1.4.4, Linux container without the sandbox runtime) has the same 22 failures onmainand on this branch (checkpoint, process pipe and warmup tests that need the runtime). No new failures.Merge Danger
Door: two-way
Revert the two lines to restore the previous behavior.
Blast Radius: small
Only
.hwp/.hwpxfiles that code writes to/mnt/dataare now uploaded as outputs. Output size and count caps still apply. MIME type falls back toapplication/octet-streamas for other unmapped extensions.