Repository navigation
wire: fix build and tests broken by the wire patch - #8
Open
bitcoinbrisbane wants to merge 1 commit into
Open
bitcoinbrisbane wants to merge 1 commit into
bitcoinbrisbane wants to merge 1 commit into
Conversation
- Restore binaryFreeList.Borrow/Return; they were removed but ~50 callers (blockheader.go, common.go, tests) still use them, so wire didn't compile. - MaxBlockHeaderPayload counts three hashes (PrevBlock, MerkleRoot, ClaimTrie), matching the 112-byte header, not btcd's two. - TestBlockHeaderWire: set ClaimTrie[0]=0x33 as the sibling test does, so the header matches its expected bytes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and Testhas been failing on master since the "Patch folder: wire" commit.wiredoesn't compile:Changes
binaryFreeList.Borrow/Return(removed, but ~50 callers remain).MaxBlockHeaderPayload= 16 + 3 hashes (112 bytes, includes ClaimTrie), fixingTestHeaders.TestBlockHeaderWire: setClaimTrie[0] = 0x33like the sibling test, so the header matches its expected bytes.Test plan
go build ./...cd wire && go test ./...passesBuild and Testgreen (other packages not run locally)🤖 Generated with Claude Code