Repository navigation
Conversation
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #3750, with the head branch hosted in Kitware/vtk-js.
Context
Uint16 values from 65520 through 65535 round to infinity in a half-float texture. Finite floating-point inputs can also overflow. A non-finite texel can affect interpolation with its neighbors. Half-float conversion
This PR is stacked on #3748. Merge that PR first, then retarget this PR to
master.Results
With half-float storage, 65535 uploads as 65504. A partial update containing -70000 and 70000 stores -65504 and 65504 respectively.
Changes
Clamp finite values to the representable range in the half-float conversion shared by full and partial WebGPU texture uploads.
PR Checklist