Repository navigation
Bugfix/issue 2553 - #2556
Open
klayoutmatthias wants to merge 5 commits into
Open
Bugfix/issue 2553#2556klayoutmatthias wants to merge 5 commits into
klayoutmatthias wants to merge 5 commits into
Conversation
added 5 commits
November 14, 2026 23:32
The problem was twofold: * While translating results back into the original layout, the clip condition was not considered properly. This caused the error markers appearing outside the clip zone. * With clip in place, two layouts are generated internally for the different input layers. While using "foreign" or "subject" as intruder layers, the correct layout has to be selected. That caused the wrong DRC output.
With the new back-annotation (aka "output to original layout"), the
clip variants are back-ported to the original layout. While doing so,
empty cells are now skipped.
For this, the cell mapping generator ("create_missing_mapping")
got a new parameter "skip_empty_cells" which is also available
in the GSI binding.
Yet, one test case needs to be adapted, and will still contain
empty cells in the output. This however is because the original
cells are not deleted, but are empty after the operation.
Fixing problems found with the unit tests. Side effects: - inserting empty deep layers into a layout will shortcut and the hierarchy will not be changed - empty cells may not be transferred to the target layout when inserting a deep layer into a layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #2553 (DRC bug with clip)
The problem was twofold:
clip condition was not considered properly.
This caused the error markers appearing outside the clip zone.
the different input layers. While using "foreign" or "subject"
as intruder layers, the correct layout has to be selected.
That caused the wrong DRC output.
This patch has some side effects:
layer to an output layout in DRC or inserting a deep region into
a layout. Specifically, less empty cells may be created.
CellMapping#create_cell_mappingnow has a parametercalled "skip_empty_cells". With this parameter set to true,
empty cells are not transferred to the target layout.
Cells are empty, if they have no shapes and are either
leaf cells or call other empty cells only.