Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PythonAstnever got a location, so the code object of module,execandevalcode spanned line 1 only:co_firstlinenowas always 1, and settingf_linenofrom a trace function failed for any line but 1.This PR sets the span of
PythonAstwhen parsing finishes, from its first statement to the end of its body, which givesco_firstlinenothe same as in CPython 3.4.It also places the entry sequence point at that start, so the 'call' trace event agrees with
co_firstlineno.I noticed also that IronPython does not handle well modules with the same name, which is quite likely when
exec-ing a string (often given a name"<string>"). This is not addressed here.