Repository navigation
Fire 'line' event for first statement of module code - #2127
Merged
Merged
Conversation
slozier
approved these changes
Nov 1, 2026
slozier
left a comment
slozier
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DLR treats the first sequence point of a lambda as the location of the 'call' trace event and fires no 'line' event for it. Function bodies emit a dedicated entry sequence point, but module,
execandevalcode did not, so their first statement never got a 'line' event.This PR adds the entry sequence point to PythonAst, at the line of the first statement, matching CPython up to 3.9 (3.10 implements PEP 626).
It also updates
test_cp24381to ignore events from the Python-implemented import machinery, which CPython traces as well, and removes its expected-failure decorator.Fixes IronLanguages/main#740 (archived repo)