Repository navigation
feat(config): let Fabric customers add, edit and remove their own AI models - #2114
Merged
Merged
Conversation
…models Host manager used to replace an instance's whole models block on each setup pass, so Studio offered no add, edit or remove on Fabric. Since HarperFast/host-manager#363 it merges Fabric's entries by name and leaves the customer's alone, so the page now offers them there too. - Remove FABRIC_KEEPS_CUSTOMER_MODELS and the "isn't available on Fabric yet" notice it guarded. - A Fabric instance below Harper 5.4 now gets the "needs Harper 5.4" notice, without the config-file hint a Fabric customer can't use. - DESIGN.md describes how the block is shared with host manager. Part of #2013 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ge loaded A cluster save checked Fabric's names as the page loaded them, and it has no stale check across several instances. So if central manager began routing a name in between, the save could write the customer's entry over Fabric's on that instance until host manager's next pass. The save already reads the cluster again to plan its targets. It now adds the names that read holds to the ones the page passed in, and refuses before any write. Off Fabric nothing is managed, as before. Part of #2013 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…stance A save to one Fabric instance used only the names the page loaded. If central manager began routing a name after that, and host manager had not yet written it, the stale check saw nothing and the customer's entry was saved, to be replaced at host manager's next pass. On a Fabric instance route the save now reads the cluster and adds that instance's names, as a cluster save already does. Off Fabric it makes no cluster read. The save hook passes the route's cluster id. Part of #2013 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kriszyp
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
On Fabric, Studio's AI Models page lists an instance's models but can't add, edit or remove one (#2013). Where Fabric supplies an instance with models, host manager used to replace the whole
modelsblock on each setup pass, so a saved model would have vanished. HarperFast/host-manager#363, now merged, keeps the customer's entries.💡 Solution
FABRIC_KEEPS_CUSTOMER_MODELSand its notice are removed.DESIGN.mdsays how the block is shared, and what a save re-reads.⚖️ Alternatives
true— it would leave a branch and a notice that can never run.🤔 Is host-manager#363 running on every Fabric host?
This PR assumes so, on @dawsontoth's word. Studio can't check it. A host still running the old host manager would drop a saved model at its next setup pass, on instances Fabric supplies with models. Reverting this PR turns the feature off again.
✅ Verification
npx vitest runpasses (730 files, 8,745 tests).tsc -b,oxlintanddprint checkare clean.🤖 Generated by Anthropic Claude (Claude Code); posted via @dawsontoth.
Related PRs: #2099 overlaps (merged; it added this page and left Fabric read-only)
Complexity: easy
Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,muse; rounds=3; full=2 @ 47bfca4
Review-Attention: read ~3m (decisions: trust-hm-deployment, cluster-id-from-route) @ 47bfca4