Repository navigation
fix(e2e): say which check refused a stage run, and skip e2e on other branches' manual runs - #2103
Merged
Merged
Conversation
The first stage gate run failed two specs on setup, not on Studio, and
both messages pointed the wrong way. Signup's 403 blamed the email-domain
allowlist, which was already right: the refusal was stage's reCAPTCHA
check ("Verification failed"), which local and dev skip. The org-users
failure called a missing organization unlikely, and that was the cause.
The signup message now names the check from central-manager's title,
and for reCAPTCHA says whether the page sent a token. The org-users spec
recognises Studio's "Create an organization" page. The deploy docs list
the three things a target's central-manager needs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A manual Deploy to Dev or Stage from any other branch still deploys, but the e2e environment admits only its own branch, so the job failed on the environment and turned a working deploy red. It now runs only on the branch its workflow deploys from, and a workflow test pins that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llowlist Review follow-ups. The signup classifier now reads the same shapes Studio's isCaptchaVerificationError does (a plain string, error, message, title, detail) and checks reCAPTCHA before Forbidden, so a mixed envelope is not sent to the allowlist. E2E_ALLOW_SIGNUP_403_SKIP now skips only a Forbidden refusal, so it cannot hide reCAPTCHA or an authz regression. The org-users check waits briefly for the new-org page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Coverage Report
File CoverageNo changed files found. |
dawsontoth
marked this pull request as ready for review
November 13, 2026 23:45
kriszyp
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
The first stage run of the post-deploy gate (run 43506503995) failed two specs on stage setup, not on Studio. Both messages pointed the wrong way: signup's 403 blamed the email-domain allowlist when reCAPTCHA had refused it, and org-users called a missing organization unlikely when that was the cause.
💡 Solution
Forbiddenis the allowlist,Verification failedis reCAPTCHA) and says whether the page sent a token.🔧 Changes
signupRefusal.tsclassifies a signup 403 by central-manager's message, reading the same shapes as Studio'sisCaptchaVerificationError, and reports whether a token was sent. The signup spec throws its message, and its opt-out now skips only an allowlist refusal.org-users.authed.spec.tsnames an account with no organization.deploy-dev.yamlanddeploy-stage.yamlrune2eonly on their own branch;workflowPrivilege.test.tspins it.deploying.mdlists what a target's central-manager needs and the manual-run skip;e2e/README.mdadds the reCAPTCHA gotcha and narrows the opt-out.✅ Verification
Re-ran the failed job twice on the same build after the stage changes. Signup now gets past reCAPTCHA, but both runs hit a central-manager login outage on stage (every sign-in since about 21:15 UTC returns 500, a regular browser session included), so the organization fix is not yet confirmed live.
signupRefusal.unit.spec.tscovers each refusal shape and the token check, andworkflowPrivilege.test.tspins the branch guard on both jobs. Each of these turns a test red: removing the guard, swapping the token branch, dropping theForbiddencase, checkingForbiddenbefore reCAPTCHA, or ignoring a plain-string body.Gate on this branch: vitest for the two workflow suites (83 tests), the e2e
unitproject (36), the e2e project'stsc --noEmit, oxlint and dprint.Not exercised live: the new messages, since stage no longer meets either condition.
🤖 Generated with Claude Code
Related PRs: #1757 overlaps (this fixes what its first stage run found)
Complexity: easy
Review-Coverage: authored=claude; ran=cursor-composer,gemini,codex,cursor-grok; late=cursor-grok:adjudicated; adjudicated=domain; declined=muse; rounds=3; full=2 @ 0d37876
Review-Attention: skim ~2m @ 0d37876