Repository navigation
docs(readme): Windows needs no loopback setup - #43
Merged
Merged
Conversation
Windows routes all of 127.0.0.0/8 to loopback by default, like Linux. harper's Windows integration shards run harper-integration-test-run, which binds every pool address before testing, with no alias setup. Only macOS needs the setup script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request updates the README.md file to clarify loopback address routing behavior across different operating systems, specifying that Linux and Windows route the entire 127.0.0.0/8 block by default, while macOS only enables 127.0.0.1 and requires the configuration script. There are no review comments, and I have no feedback to provide.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README says Windows doesn't enable the extra loopback addresses, but it does: Windows routes all of
127.0.0.0/8to loopback by default, the same as Linux. Only macOS needsharper-integration-test-setup-loopback.How I checked: harper's Windows integration shards run
harper-integration-test-runwith no alias setup. At the runner's default concurrency (3 on a 4-vCPUwindows-latestrunner), it binds every pool address (127.0.0.2to127.0.0.33) before testing and exits if any fail. Those shards pass, for example in this main run.This only changes the setup section. The foreign-listener note that groups Windows with macOS is about a different behavior and is still correct.
sent with Claude Opus 5.5