Repository navigation
Banners: report the close of "until dismissed" banners - #205
Merged
Merged
Conversation
An until-dismissed banner (action.untilDismissed) sends the streamed event outbound-<id>-closed when its X or a button closes it, flushed right away, and is remembered per contact in localStorage. A remembered banner is not shown again; the close is re-sent once per page load so a close that never reached the server heals. One already on screen is not injected again on the next trigger. Other banners behave as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until dismissed banners: shown on every page load until the person closes them. Server: GleapSDK/Server#2838 · Dashboard: GleapSDK/Frontend#2882
What changes (GleapBannerManager)
untilDismissed: truereports its close (the X or any banner button, both postbanner-close) as the streamed eventoutbound-<outboundId>-closed, flushed right away instead of on the next 2.5 s tick.gleap-closed-banners-<gleapId>in localStorage, max 50). A remembered banner is not shown again; the close is re-sent once per page load, so a close that never reached the server (tab closed before the flush) heals.Release
Must ship as 19.5.0: the server only enables the mode for JS SDK ≥ 19.5.0 (
UNTIL_DISMISSED_MIN_JS_SDK). If the version differs, update it in the Server and Frontend PRs.build/andpublished/are untouched; the release step generates them.Testing
npx jest: 619/619 pass (7 new tests inGleapBannerManager.test.js).npm run buildcompiles.🤖 Generated with Claude Code