Skip to content

fix(edges): edges of a surface behind another one no longer show through it - #208

Open
SpliiT wants to merge 3 commits into
nextfrom
fix/edges_behind_surfaces
Open

SpliiT wants to merge 3 commits into
nextfrom
fix/edges_behind_surfaces

Conversation

@SpliiT

@SpliiT SpliiT commented Nov 20, 2026

Copy link
Copy Markdown
Member

Fixes Geode-solutions/Vease#832

Since the edges got their own wireframe actors (mesh edges attributes, model edges styled per component), the edges of a surface lying just below another one show through it: on the Pukekohe model, internal surfaces edges are drawn over the topography near the outcrops.

The coincident topology offsets set in add_object are global (VTK static setters): polygons are pushed back by 2 × their depth slope, lines by only 1 ×. Edges drawn as lines are therefore in front of any surface less than about one slope ahead of them. Before, edges were drawn in the polygons pass (EdgeVisibility) at the exact depth of their own surface.

The edges actors (mesh ensure_edges_actor, model sync_edges_width_actors) now get a relative line offset factor, half of the gap between the polygons and lines factors (read from the global offsets, not hard coded).

Measured on the Pukekohe 7d model (topography edges red, internal surfaces edges black, views from above): internal edges showing through the topography drop by about two thirds, the topography's own edges are unchanged. The full gap removes a bit more but thins wide edges on sharp folds (cube corners), behind their own surface. What remains are short bits where two surfaces meet, at the same depth: no offset separates them, only drawing the edges back in the polygons pass would.

Model lines now show over the edges of the surfaces they bound, as before the edges actors: 7 model edges reference images are updated for that. The mesh edges references are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants