Repository navigation
Conversation
JulienChampagnol
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Geode-solutions/Vease#832
Since the edges got their own wireframe actors (mesh edges attributes, model edges styled per component), the edges of a surface lying just below another one show through it: on the Pukekohe model, internal surfaces edges are drawn over the topography near the outcrops.
The coincident topology offsets set in
add_objectare global (VTK static setters): polygons are pushed back by 2 × their depth slope, lines by only 1 ×. Edges drawn as lines are therefore in front of any surface less than about one slope ahead of them. Before, edges were drawn in the polygons pass (EdgeVisibility) at the exact depth of their own surface.The edges actors (mesh
ensure_edges_actor, modelsync_edges_width_actors) now get a relative line offset factor, half of the gap between the polygons and lines factors (read from the global offsets, not hard coded).Measured on the Pukekohe 7d model (topography edges red, internal surfaces edges black, views from above): internal edges showing through the topography drop by about two thirds, the topography's own edges are unchanged. The full gap removes a bit more but thins wide edges on sharp folds (cube corners), behind their own surface. What remains are short bits where two surfaces meet, at the same depth: no offset separates them, only drawing the edges back in the polygons pass would.
Model lines now show over the edges of the surfaces they bound, as before the edges actors: 7 model edges reference images are updated for that. The mesh edges references are unchanged.