Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Geode-solutions/Vease#869
Clicking a leaf row in an object tree selected it and toggled its visibility, so selecting a visible object hid it from the viewer. Visibility is now only changed by the eye button.
CommonTreeView: a plain click no longer callstoggleSelect; it only updates the active items and emitsclick:item.ModelTree: removes theclick:itemlistener that forced the clicked component visible (left over from the treeview merge).Enter and Space go through the same click handler, so they now select without changing visibility either.
Unit test: clicking a hidden or a visible row emits
update:activeand neverupdate:selected. Checked in the Vease browser build: the clicked surface stays displayed.