Repository navigation
Conversation
save_viewable_file now answers once the viewables are written. The native re-save (kept so files are always written in the latest format) runs on a background executor, one entry per data id, saves of the same data chained. Every reader, writer or deleter of the native file waits for it first: load_geode_object, load_crs_object, apply_time_series, export_project, the import rollback and the data folder reset. A failed save is retried once, then the request needing the file fails with a 500. On a 284 MB structural model, the server answers in 6.3 s instead of 10.1 s and the first image arrives 2 s earlier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BotellaA
force-pushed
the
perf/background_native_save
branch
from
November 20, 2026 13:56
30423b2 to
c06e164
Compare
JulienChampagnol
approved these changes
Nov 20, 2026
Merge origin/next into perf/background_native_save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 120077c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Importing a large model (284 MB
.og_strm) waited for the native re-save before answering, about 4.5 s that the viewer does not need: it only reads the viewables.What
save_viewable_fileanswers once the viewables are written. The native re-save still runs for every input, native or not, so files stay in the latest format. It now runs on a background executor, one entry per data id, and saves of the same data are chained.load_geode_object(covers most routes)load_crs_object(CRS conversion and assignment)apply_time_seriesexport_project(waits for every pending save)Measured
Vease,
3_meshed_300m.og_strm, mean of 3 runs:Tests
tests/test_background_native_save.py(12 tests): the route answers while the save is blocked, readers wait, failed saves, parallel imports, export, and a CRS assignment made during the save.ruffandmypyare clean.Limits
🤖 Generated with Claude Code