Repository navigation
MOB-518: per-node multi-pointer on_touch - #238
Merged
Merged
Conversation
…e, captured by the down node)
Owner
Author
|
Android device verification (Moto G Power 2021, Android 11), fixture
Note, not a regression: a finger that lifts inside an Still open: real two-finger on the iPhone (needs a person; XCTest can't synthesize two pointers on a physical device), iOS 17, release builds. |
Merged
GenericJam
added a commit
to GenericJam/mob_new
that referenced
this pull request
Nov 13, 2026
MOB-518. Android verified on a Moto G Power 2021; see GenericJam/mob#238.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-518:
on_touchon any node. Each finger arrives as its own{:touch, tag, %{phase: :down | :move | :up | :cancel, pointer_id, x, y, width, height, ts}}stream. x and y are in dp relative to the node. A finger stays with the node it went down on until it lifts. Moves are opt-in (moves: true, throttled per pointer natively). The down is delivered without a disambiguation delay, and the observer never consumes events. Design:decisions/2026-11-12-per-node-multi-pointer-on-touch.md.Android bridge: GenericJam/mob_new (branch MOB-518-on-touch, linked PR). Linear: MOB-518.
Verification
zig test touch_throttle.zigpasses,test/nativetouch_throttle_test passes, and the iOS NIF (debug + release, with Swift) compiles.Release gate (review finding, deliberately deferred): generated apps call the new
mob_touch_*symbols. So mob_new's mob floor must move to the mob release that contains this PR, at release time. That version doesn't exist yet, and pinning it now would break generator CI at deps.get.Reviewer: reviewer subagent (Codex rate-limited until ~9:31 PM). First pass DO NOT SHIP. Fixed since: on_touch is kept on gpu_view, and the touch observer has a distinct Compose key. The dependency floor is deferred as above. Re-review is pending.