Skip to content

fix small bug in one of the spergel deriv tests - #270

Merged
beckermr merged 1 commit into
GalSim-developers:mainfrom
ismael-mendoza:fix-spergel-deriv-test
Nov 13, 2026
Merged

beckermr merged 1 commit into
GalSim-developers:mainfrom
ismael-mendoza:fix-spergel-deriv-test

Conversation

@ismael-mendoza

Copy link
Copy Markdown
Collaborator

No description provided.

@beckermr
beckermr merged commit fdcaedc into GalSim-developers:main Nov 13, 2026
9 of 11 checks passed
@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 4.33%

3 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 12 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 36 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 1.7 ms 2.6 ms -36.11%
⚡ CPU Simulation test_benchmarks_lanczos_interp[xval-conserve_dc-run] 3.1 ms 2.2 ms +43.27%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ismael-mendoza:fix-spergel-deriv-test (294180d) with main (10add4c)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants