Repository navigation
Conversation
…effective profile rather than resampling.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Piff, one of my recent changes (rmjarvis/Piff#213) involves drawing an analytic derivative of a profile to get the gradient for the fit. This works fine when it's achromatic, but fails when I do this in a chromatic drawing context. It turns out there were two separate problems.
_fiducial_profilelook at ref_sed to find a good wavelength. This also fixed some places where normalization would involve division by zero when the flux is zero._get_effective_prof.