Skip to content

Fix how the Roman PSF is rotated to the right sky orientation - #1377

Open
rmjarvis wants to merge 3 commits into
releases/2.8from
roman_psf_skycoords
Open

rmjarvis wants to merge 3 commits into
releases/2.8from
roman_psf_skycoords

Conversation

@rmjarvis

Copy link
Copy Markdown
Member

When working on fitting the PSF of Roman commissioning data, I realized we have a bug in the Roman getPSF function in terms of how we rotate the PSF to sky coordinates according to how the telescope is oriented. We just apply the wcs.toWorld() function. This gets the rotation and reflection (approximately) correct, but also applies the distortion, which is wrong. The upshot of the bug is that the PSF is not properly distorted when drawn with the same WCS. This PR fixes this to just apply the orthogonal part of the WCS without the distortion (symmetric positive definite part).

However, using the WCS for this is an approximation, which is still not completely correct. The WCS can include rotation components from pixel geometry, which are not properly part of the rotation we want. It turns out the Roman ASDF files include the information we need to do this correctly. Namely the boresight direction and the position angle of the V3 axis. So I also added the option to provide these directly, which does the more correct rotation. The rotation angle can still change slightly across the field of view, due to the direction to north changing slightly. But any other rotation in the WCS will be applied correctly when the object is drawn on an image.

@rmjarvis rmjarvis added bug report Bug report roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module. labels Nov 12, 2026
@rmjarvis rmjarvis added this to the v2.8 milestone Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug report Bug report roman Relevant to Roman Space Telescope specifically, especially including the galsim.roman module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant