Skip to content

remove requirements files in favor of dependency extras (pip install .[test]) - #1372

Open
zacharyburnett wants to merge 8 commits into
GalSim-developers:releases/2.8from
zacharyburnett:remove_requirements_files
Open

zacharyburnett wants to merge 8 commits into
GalSim-developers:releases/2.8from
zacharyburnett:remove_requirements_files

Conversation

@zacharyburnett

@zacharyburnett zacharyburnett commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

it appears to me that these requirements.txt files are redundant, and can be removed in favor of using pip install . / pip install .[test]. To make a conda environment with these pip packages do

conda env create -c conda-forge -n my_galsim_env python numpy fftw eigen
conda activate my_galsim_env
pip install .

(unless it's required that GalSim dependencies all be installed as Conda packages? In which case conda_requirements.txt is useful)

@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch 2 times, most recently from 65c30da to 09880ce Compare October 20, 2026 19:01
@zacharyburnett
zacharyburnett marked this pull request as ready for review October 20, 2026 19:06
@rmjarvis

Copy link
Copy Markdown
Member

I don't mind the changes to ci.yml and setup.py, however, the current version seems to have broken ci, so you should fix that.

But removing the requirement files means you also need to update the docs that tell people to use them. You should update them to the correct installation instructions given the changes you made.

@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from 09880ce to 483e20f Compare October 22, 2026 12:18
@zacharyburnett
zacharyburnett marked this pull request as draft October 22, 2026 12:19
@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from b375f91 to c416f8d Compare October 29, 2026 18:30
@zacharyburnett
zacharyburnett marked this pull request as ready for review October 29, 2026 18:48
@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from c416f8d to ef147bf Compare November 2, 2026 14:17

@rmjarvis rmjarvis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good to remove the old setup.py instructions, which are no longer recommended. I think the conda stuff needs to stay though.

Comment thread .github/workflows/ci.yml Resolved
Comment thread docs/install.rst Resolved
Comment thread docs/install_conda.rst Resolved
Comment thread examples/demo1.yaml Resolved
Comment thread conda_requirements.txt Resolved
@rmjarvis rmjarvis added the build Related to compiling, building, installing label Nov 12, 2026
@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from ef147bf to 224b07f Compare November 12, 2026 13:25
Comment thread conda_requirements.txt Resolved
@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from 94d40de to 99c0bd9 Compare November 13, 2026 14:02
@zacharyburnett

zacharyburnett commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor Author

rebased against the new state of release/2.8, thank you again for your patience as I worked on this. Hopefully this makes building and testing GalSim releases easier!

@zacharyburnett
zacharyburnett force-pushed the remove_requirements_files branch from 24f8ced to 07e2b87 Compare November 13, 2026 14:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to compiling, building, installing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants