Repository navigation
Update fix tests - #19
Merged
beckermr merged 10 commits intoNov 13, 2026
Merged
Conversation
* Flip to WFI coords and document the flip Flipped the coordinate system, and added some justification/documentation * Fixed to use galsim transformation isntead --------- Co-authored-by: Nihar Dalal <140463192+nihardalal@users.noreply.github.com> Co-authored-by: nihardalal <nihardalal@rocketmail.com>
beckermr
reviewed
Nov 11, 2026
beckermr
requested changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK @beckermr I updated my branch so now it's pointing to the latest changes in the
mainbranch of GalSim. Also I added two fixes related to the CI errors we are seeing now in GalSim-developers/JAX-GalSim#267. One is due to the sinc implementation changing in jax, and the other is due to adding a new keyword argument indrawKImagein that PR.Please let me know if anything is unclear and we can also discuss on Friday