Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Shared host/microVM mounts can lose local executable bits while Git still records
the intended mode. Offline Bats/pre-commit runs also retained a controlling
terminal after detaching stdin, allowing installer fixtures to consume a human
response through
/dev/tty. macOS exposed additional fixture and provider-inputpath portability defects that Linux-only checks did not catch.
These concerns cross the same test boundary: the runner executes the installer,
provider projection depends on secure pre-bootstrap path handling, and tests must
validate the Git metadata a fresh checkout receives. This PR integrates those
protections as one coherent test-integrity change.
Changes
scripts/validate-git-executable-modes, a read-only stage-0 Git-indexcheck requiring intended direct entrypoints to be
100755.npm run validate:exec-bits.shared-mount repair via
scripts/fix-exec-bits.consent-gated actions cannot borrow
/dev/ttyduring pre-commit.publication, and cleanup use one resolved, supported host Python interpreter.
retaining component-by-component
O_NOFOLLOWtraversal.terminal interaction, double-slash temporary paths, and repository-local
TMPDIRtransport staging.Verification
macOS host
The run included macOS path-alias, restricted-PATH validator, terminal prompt,
provider-projection, credential, and vendored-Bats mode coverage. No host MSB,
Homebrew, VM, or credential operation was invoked by the tests.
Additional review
prior installer prompt or terminal hang.
Known limitation
The full offline suite still has a pre-existing MSYS fixture failure outside this
change. This PR does not claim a clean full-suite result. Local Bash 3.2 execution
was not available; the existing CI Bash 3.2 shard remains the compatibility gate.
Security impact
of trusting mount-specific filesystem metadata.
for installer consent.
when a suitable pre-bootstrap Python interpreter is unavailable.
are changed.
Rollback
Revert this PR. The executable gate, noninteractive test-runner behavior, and
provider-input portability changes are self-contained.
AI assistance
Implementation and review were AI-assisted. The macOS validation was performed
by the human operator. Human review is required before production use.