Repository navigation
Send random_tls_extension_order for custom TLS profiles - #170
Open
milkyontheblock wants to merge 1 commit into
Open
milkyontheblock wants to merge 1 commit into
milkyontheblock wants to merge 1 commit into
Conversation
withRandomTLSExtensionOrder was only added to the request payload in the preset branch (client_identifier set). With client_identifier=None and a ja3_string, the option was silently dropped, so the extension order stayed fixed on every connection. Send it for both branches and cover the custom profile with a test.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Session(client_identifier=None, ja3_string=..., random_tls_extension_order=True)has no effect. Inexecute_request,withRandomTLSExtensionOrderis only added to the payload in theelsebranch (preset profiles), so for a custom profile the option is silently dropped and the extension order is identical on every connection.Fix
Add
withRandomTLSExtensionOrderto the payload before theclient_identifier is Nonebranch, so it applies to both preset and custom profiles.Verification
test_random_extension_order_is_sent_with_a_custom_profile: fails before the change, passes after.https://tls.peet.ws/api/allwith a custom JA3: before, the extension order was identical across sessions; after, it differs per session (6 different JA3 hashes in 6 runs) and the JA4 stays the same, as expected since JA4 sorts extensions.