Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The configured search or reranking depth is applied before excluded candidates are removed. Dense retrieval can return fewer eligible documents when a query ID also occurs in the corpus. BRIGHT retrieval has the same issue for its per-query exclusion lists, and reranking can discard a valid candidate at the depth boundary when an identical ID occupies an earlier slot.
Changes
N/Asentinel behavior.Validation
Added 30 tests using local tiny BERT models, the native embedder/reranker, and FAISS. Retrieval results are compared with a full NumPy similarity ranking after applying the same eligibility rules. Cases cover depths 1, 2, and larger than the corpus; multiple BRIGHT exclusions; queries with and without corpus IDs; and enabled/disabled identical-ID filtering.
git diff --checkpassed.This change fixes candidate selection depth. It does not change embedding scores, reranking scores, or exclusion policy.