Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The layerwise training wrapper records
start_layerbut does not passcutoff_layersto its backbone. The backbone defaults to returning only the final layer. As a result, intermediate layer scores never reach the training loss: their supervised loss is missing, the self-distillation loop has no student layers, and independent intermediate classifier heads receive no gradients.Changes
Pass the complete requested range, from
start_layerthroughnum_hidden_layers, when the training wrapper encodes pairs. The existing loss already supports multiple layer outputs, so no loss formula or backbone default needs to change. This also restores the layer selection used by the repository's earlier research training implementation in the current package entry point.Validation
LayerWiseMiniCPMForCausalLMexercises shared and independent heads, three starting layers, external teacher targets, and self-distillation.git diff --checkpass.