Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reranker collators flatten each query's positive and negative passages, but the model reshapes their scores using the configured training batch size. A final DataLoader batch with fewer queries can therefore mix candidates from different queries, raise a reshape error, or create one-candidate groups with zero cross-entropy. The same grouping also affects teacher targets and layerwise distillation.
Changes
group_sizein both reranker collators.The group-size metadata stays valid when tensors are split at complete query-group boundaries. This change does not address existing DataParallel behavior for Python-list teacher scores or tensor splits through the middle of a query group.
Validation
git diff --checkpass.