Repository navigation
fog.enrollsb: do not complete a task when the menu started the run - #203
Merged
Merged
Conversation
The PXE menu item "Enroll Secure Boot Key (Unattended)" boots fog.enrollsb with no task scheduled. The enrollment succeeded, then fog.nonimgcomplete asked Post_Wipe.php to close a task that did not exist. The server answered "No Active Task found" eleven times and handleError ended a good enrollment on an error screen (forum topic 18307). sbReport already asks the server first. An answer of ##notasking or ##unknownhost now sets sbNoTask=1, prints why the server keeps no record, and fog.enrollsb skips fog.nonimgcomplete. A scheduled task is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The PXE menu item "Enroll Secure Boot Key (Unattended)" boots
fog.enrollsbwith no task scheduled. The enrollment succeeds. Thenfog.nonimgcompleteasksPost_Wipe.phpto close a task that does not exist. The server answers "No Active Task found" eleven times, andhandleErrorends a good enrollment on an error screen. Reported on forum topic 18307 with release20261105-164908.Fix
sbReportalready askssecureboot.report.phpbefore the task completes. An answer of##notaskingor##unknownhostnow setssbNoTask=1. It prints a note that no task is scheduled, so the server keeps no record.fog.enrollsbskipsfog.nonimgcompletewhensbNoTask=1.Tests
tests/checks/secureboot-enrollment-report.sh: 18 passed.##notaskingand##unknownhostset the flag.fog.enrollsbagainst stubs.tests/checks/secureboot.sh: 95 passed.Not tested on a live menu boot.
🤖 Generated with Claude Code