Repository navigation
fog.man.reg: ask for the FOG login on the domain-join question - #200
Merged
Merged
Conversation
The server now copies the domain join account onto a newly registered host only for a signed-in operator who may create hosts (FOGProject/fogproject#2054). This screen asked for a login only before imaging, so "join domain yes, image no" could never pass. The login prompt moves into fogLogin(), which both questions call. It asks once: an operator who signed in for the domain question is not asked again before imaging. A rejected login answers no to the question that needed it, and its username and password are cleared so they do not reach the registration POST. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FOGProject/fogproject#2054 makes the server copy the domain join account onto a newly registered host only for a signed-in operator who may create hosts. This screen asks for a FOG login only before imaging. So "join domain: yes, image now: no" sends no login, and the host registers without domain settings.
Fix
The login prompt moves into
fogLogin(). The domain question and the imaging question both call it. It asks once per registration. A rejected login (three tries) answers no to the question that needed it, and it clears the username and password so they do not reach the registration POST.Test
bash -nis clean. The screen is interactive, so no automated test drives it.🤖 Generated with Claude Code