Repository navigation
Honor the configured Discord private-message format - #6644
Merged
Merged
Conversation
…scord/DiscordSettingsTest.java
JRoy
approved these changes
Nov 3, 2026
Member
|
Thanks! |
JRoy
added
bug: confirmed
JRoy
enabled auto-merge
November 3, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #6641.
Details
Proposed fix:
Read the private-message format from
messages.pms-to-discord, matching the shipped config. The settings loader currently readsmessages.private-chatinstead, so a custom format is ignored and the default[SocialSpy]text is used.Added settings tests that load real YAML files and check the custom format, default fallback and reload, including placeholders and apostrophes. The Discord module now includes the core project on its test classpath.
Environments tested:
OS: Windows
Java version: Temurin 25.0.4.1+1
The full Gradle build passes, including the new settings tests and Checkstyle. Live Paper/Discord relay testing was not performed.
Demonstration:
The regression loads this configuration:
Before the fix, the actual settings loader produces
[SocialSpy] sender -> receiver: Hello. After the fix, it produces[Privado] Sender -> Receiver: Hello. The missing-key control keeps the existing default.