Repository navigation
Study nothrow use - #3773
Merged
Merged
Study nothrow use#3773
Conversation
added 2 commits
November 22, 2026 12:49
…ANG64, " unit tests, so remove only NOTHROW reference in Highs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3773 +/- ##
==========================================
- Coverage 75.98% 75.98% -0.01%
==========================================
Files 467 467
Lines 116543 116544 +1
Branches 18163 18165 +2
==========================================
- Hits 88555 88551 -4
- Misses 27748 27753 +5
Partials 240 240 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
The issue is not in HiGHS, it's in Catch. The runner must have updated its version of Clang and somehow a header is not pulled in automatically anymore. We just need to add |
Member
Author
That was plan B: I'll do it |
filikat
approved these changes
Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why does use of
nothrowinextern/catch/catch.hppcause failure in "mingw (CLANG64, " unit tests?Failure relates to
check/CMakeFiles/unit_tests.dir/TestHighsCDouble.cpp, but only reference tonothrowin Highs is inTestMipSolver.cpp.Checklist
latestbranch