Skip to content

Study nothrow use - #3773

Merged
jajhall merged 3 commits into
latestfrom
study-nothrow-use
Nov 22, 2026
Merged

jajhall merged 3 commits into
latestfrom
study-nothrow-use

Conversation

@jajhall

@jajhall jajhall commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Description

Why does use of nothrow in extern/catch/catch.hpp cause failure in "mingw (CLANG64, " unit tests?

Failure relates to check/CMakeFiles/unit_tests.dir/TestHighsCDouble.cpp, but only reference to nothrow in Highs is in TestMipSolver.cpp.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Julian Hall added 2 commits November 22, 2026 12:49
…ANG64, " unit tests, so remove only NOTHROW reference in Highs
@codecov

codecov Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.98%. Comparing base (3a864cc) to head (a63cfeb).
⚠️ Report is 9 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3773      +/-   ##
==========================================
- Coverage   75.98%   75.98%   -0.01%     
==========================================
  Files         467      467              
  Lines      116543   116544       +1     
  Branches    18163    18165       +2     
==========================================
- Hits        88555    88551       -4     
- Misses      27748    27753       +5     
  Partials      240      240              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@filikat

filikat commented Nov 22, 2026

Copy link
Copy Markdown
Collaborator

The issue is not in HiGHS, it's in Catch. The runner must have updated its version of Clang and somehow a header is not pulled in automatically anymore. We just need to add #include <new> to catch.hpp

@jajhall

jajhall commented Nov 22, 2026

Copy link
Copy Markdown
Member Author

The issue is not in HiGHS, it's in Catch. The runner must have updated its version of Clang and somehow a header is not pulled in automatically anymore. We just need to add #include <new> to catch.hpp

That was plan B: I'll do it

@jajhall
jajhall requested a review from filikat November 22, 2026 13:29
@jajhall jajhall self-assigned this Nov 22, 2026
@jajhall jajhall added the Build label Nov 22, 2026
@jajhall
jajhall merged commit b021270 into latest Nov 22, 2026
577 checks passed
@jajhall
jajhall deleted the study-nothrow-use branch November 22, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants