Skip to content

Hipdlp interrupt - #3764

Open
Yanyu000 wants to merge 1 commit into
latestfrom
hipdlp-interrupt
Open

Yanyu000 wants to merge 1 commit into
latestfrom
hipdlp-interrupt

Conversation

@Yanyu000

@Yanyu000 Yanyu000 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Add kCallbackPdlpInterrupt so that HiPDLP solves can be interrupted, like simplex and IPM solves.

  • New callback type kCallbackPdlpInterrupt (value 12, appended to the enum so existing values are unchanged), kHighsCallbackPdlpInterrupt in the C API, and cbPdlpInterrupt in highspy. It is checked in the main loop next to the time limit, so there is no per-iteration cost. The model status is kInterrupt if the user interrupts.
  • HiPDLP previously only copied its iterate to the output on convergence, so a time limit, iteration limit or interrupt returned the initial point. It now returns the latest iterate.
  • Added a test (highs-callback-pdlp-interrupt) and documentation. cuPDLP-C is not changed.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@codecov

codecov Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.13421% with 290 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (6249d90) to head (c0db739).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
highs/util/HighsAvailableMemory.cpp 0.00% 56 Missing ⚠️
highs/io/HMpsFF.cpp 73.19% 52 Missing ⚠️
highs/lp_data/Highs.cpp 81.48% 30 Missing ⚠️
highs/ipm/hipo/ipm/FactorHighsSolver.cpp 0.00% 25 Missing ⚠️
check/TestSolverSelect.cpp 91.33% 22 Missing ⚠️
highs/ipm/hipo/ipm/Solver.cpp 0.00% 17 Missing ⚠️
highs/io/HMPSIO.cpp 76.81% 16 Missing ⚠️
highs/util/HighsSolverSelect.cpp 94.01% 14 Missing ⚠️
highs/ipm/hipo/ipm/UpLookingSolver.cpp 0.00% 12 Missing ⚠️
highs/ipm/hipo/factorhighs/FactorHighs.cpp 0.00% 7 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
+ Coverage   75.95%   75.98%   +0.02%     
==========================================
  Files         461      467       +6     
  Lines      114730   116539    +1809     
  Branches    17976    18170     +194     
==========================================
+ Hits        87145    88549    +1404     
- Misses      27299    27750     +451     
+ Partials      286      240      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall
jajhall self-requested a review November 21, 2026 10:15
@jajhall jajhall added Enhancement New feature or request HiPDLP labels Nov 21, 2026
@jajhall
jajhall changed the base branch from master to latest November 21, 2026 10:35
clone.startCallback(kCallbackMipInterrupt);
clone.startCallback(kCallbackSimplexInterrupt);
clone.startCallback(kCallbackIpmInterrupt);
clone.startCallback(kCallbackPdlpInterrupt);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, since PDLP wouldn't be used in solving the LP/MIP

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo comment

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request HiPDLP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants