Skip to content

Add HIGHS_TEST_EXACT_ITERATIONS for distribution builds - #3759

Merged
galabovaa merged 1 commit into
latestfrom
ctest
Nov 20, 2026
Merged

galabovaa merged 1 commit into
latestfrom
ctest

Conversation

@galabovaa

@galabovaa galabovaa commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

Exact simplex iteration counts depend on compiler and flags, so Debian runs the C++ tests only on amd64, and Ubuntu skips them on amd64v3.

This adds HIGHS_TEST_EXACT_ITERATIONS. It is ON by default, so tests are unchanged. It turns OFF automatically for builds with custom flags (for example a None build type, or -O*, -march or -mfma in CMAKE_CXX_FLAGS). When OFF, the tests check only status and objective, run on all architectures, and skip the PDLP tests.

Tested: 1.16.0 built with -march=x86-64-v3 now passes 150 of 150 tests, where 7 failed before.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

@galabovaa
galabovaa requested a review from jajhall November 20, 2026 17:02
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.96%. Comparing base (dcf8061) to head (38856a1).
⚠️ Report is 68 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3759      +/-   ##
==========================================
+ Coverage   75.85%   75.96%   +0.11%     
==========================================
  Files         461      467       +6     
  Lines      115588   116460     +872     
  Branches    18059    18162     +103     
==========================================
+ Hits        87677    88471     +794     
- Misses      27671    27749      +78     
  Partials      240      240              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine, but we can probably drop the iteration count checks, as they were originally there so that I could check that I'd not broken Qi's original code.

The simplex solver features are being tested so well with all the instance tests involving MIPs that any failure would be readily exposed

@galabovaa
galabovaa merged commit ca5f15f into latest Nov 20, 2026
575 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants