Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3759 +/- ##
==========================================
+ Coverage 75.85% 75.96% +0.11%
==========================================
Files 461 467 +6
Lines 115588 116460 +872
Branches 18059 18162 +103
==========================================
+ Hits 87677 88471 +794
- Misses 27671 27749 +78
Partials 240 240 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jajhall
approved these changes
Nov 20, 2026
jajhall
left a comment
Member
There was a problem hiding this comment.
Sounds fine, but we can probably drop the iteration count checks, as they were originally there so that I could check that I'd not broken Qi's original code.
The simplex solver features are being tested so well with all the instance tests involving MIPs that any failure would be readily exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exact simplex iteration counts depend on compiler and flags, so Debian runs the C++ tests only on amd64, and Ubuntu skips them on amd64v3.
This adds HIGHS_TEST_EXACT_ITERATIONS. It is ON by default, so tests are unchanged. It turns OFF automatically for builds with custom flags (for example a None build type, or -O*, -march or -mfma in CMAKE_CXX_FLAGS). When OFF, the tests check only status and objective, run on all architectures, and skip the PDLP tests.
Tested: 1.16.0 built with -march=x86-64-v3 now passes 150 of 150 tests, where 7 failed before.
Checklist
latestbranch