Repository navigation
Conversation
…ges made by the solve of a particular Highs instance, so a model passed in can't validly carry any. In the MIP solver, the LP relaxation inherited the original model's inf-cost mods via the presolved model copy, and restoreInfCost() indexed beyond its 82 columns. Adds the reporter's model as issue-3756 and removes a TestCallbacks block made trivial by the change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3757 +/- ##
==========================================
+ Coverage 75.85% 75.97% +0.12%
==========================================
Files 461 467 +6
Lines 115588 116460 +872
Branches 18059 18165 +106
==========================================
+ Hits 87677 88484 +807
- Misses 27671 27736 +65
Partials 240 240 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing, in favour of #3756 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discard mods_ of a model passed to Highs (fixes #3756)
Copies of an LP made mid-solve (presolved MIP model, LP relaxation)
carried the outer solve's inf-cost mods, indexed into the original
model, so restoreInfCost() wrote beyond the smaller LP's vectors.
Checklist
latestbranch