Skip to content

Fix 3756 - #3757

Closed
galabovaa wants to merge 1 commit into
latestfrom
issue-3756
Closed

galabovaa wants to merge 1 commit into
latestfrom
issue-3756

Conversation

@galabovaa

@galabovaa galabovaa commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Description

Discard mods_ of a model passed to Highs (fixes #3756)

Copies of an LP made mid-solve (presolved MIP model, LP relaxation)
carried the outer solve's inf-cost mods, indexed into the original
model, so restoreInfCost() wrote beyond the smaller LP's vectors.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

…ges made by the solve of a particular Highs instance, so a model passed in can't validly carry any. In the MIP solver, the LP relaxation inherited the original model's inf-cost mods via the presolved model copy, and restoreInfCost() indexed beyond its 82 columns. Adds the reporter's model as issue-3756 and removes a TestCallbacks block made trivial by the change.
@galabovaa
galabovaa requested a review from jajhall November 20, 2026 14:18
@galabovaa galabovaa self-assigned this Nov 20, 2026
@galabovaa
galabovaa requested a review from filikat November 20, 2026 14:23
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.97%. Comparing base (dcf8061) to head (c996ba4).
⚠️ Report is 68 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3757      +/-   ##
==========================================
+ Coverage   75.85%   75.97%   +0.12%     
==========================================
  Files         461      467       +6     
  Lines      115588   116460     +872     
  Branches    18059    18165     +106     
==========================================
+ Hits        87677    88484     +807     
- Misses      27671    27736      +65     
  Partials      240      240              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa

Copy link
Copy Markdown
Contributor Author

Closing, in favour of #3756 (comment)

@galabovaa galabovaa closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant