Skip to content

Fix 3749 - #3752

Merged
filikat merged 3 commits into
latestfrom
hipo-max
Nov 21, 2026
Merged

filikat merged 3 commits into
latestfrom
hipo-max

Conversation

@filikat

@filikat filikat commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Handle objective sense for maximisation correctly in HiPO.

Checklist

  • I have read the contributing guidelines
  • This PR targets the latest branch
  • Tests are passing
  • Documentation was updated where relevant
  • This PR is not primarily AI-generated (per the AI contributions policy in CONTRIBUTING.md)

Related issue

Closes #3749

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.94%. Comparing base (dcf8061) to head (9b7c39a).
⚠️ Report is 68 commits behind head on latest.

Files with missing lines Patch % Lines
highs/ipm/hipo/ipm/Iterate.cpp 0.00% 5 Missing ⚠️
highs/ipm/hipo/ipm/Model.cpp 0.00% 4 Missing ⚠️
highs/ipm/hipo/ipm/KktMatrix.cpp 0.00% 2 Missing ⚠️
highs/ipm/hipo/ipm/Solver.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3752      +/-   ##
==========================================
+ Coverage   75.85%   75.94%   +0.09%     
==========================================
  Files         461      467       +6     
  Lines      115588   116398     +810     
  Branches    18059    18160     +101     
==========================================
+ Hits        87677    88404     +727     
- Misses      27671    27754      +83     
  Partials      240      240              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to scale the copy of Q rather than use sense in all the necessary places, and consistent with the scaling of the objective and costs

@filikat
filikat merged commit 725b40f into latest Nov 21, 2026
574 of 575 checks passed
@filikat
filikat deleted the hipo-max branch November 21, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants