Repository navigation
Conversation
jajhall
reviewed
Nov 19, 2026
jajhall
reviewed
Nov 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3743 +/- ##
=======================================
Coverage 75.84% 75.85%
=======================================
Files 461 461
Lines 115554 115588 +34
Branches 18055 18059 +4
=======================================
+ Hits 87646 87677 +31
- Misses 27668 27671 +3
Partials 240 240 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jajhall
requested changes
Nov 19, 2026
jajhall
left a comment
Member
There was a problem hiding this comment.
Very minor simplifications, otherwise this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v1.16, every
Highs::run()calledavailable_core_count(). On Linux that function opens two sysfs files per CPU. With the defaultthreads=0it ran twice per run, and once more per MIP solve. Each time, the result was either unused or used only for a log line that wasn't printed.This PR skips those calls:
initialize_scheduler(): compute the default thread count only if the scheduler isn't already running. A running scheduler ignores the count anyway.Highs::initializeMultiThreading(): compute the core count only when dev logging is on.output_flagis on.When logging is on, the output is unchanged. The declaration of
available_core_count()now warns not to call it per solve.I chose this over the caching patch suggested in the issue because it adds no global state. On the issue's repro the two perform the same.
Timings (issue's 2×2 LP repro, Linux, 22 CPUs, median of 7 interleaved runs):
threads=1threads=0(default)Checklist
latestbranch