Repository navigation
Use real chain configuration in collateral policy tests - #1154
Merged
Merged
Conversation
|
✅ Deploy Preview for sovryn-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-merge Node 22 job failed before the collateral-policy assertions because a real network lookup received the numeric test chain ID
31. The test's virtual workspace-package mocks supplied numeric IDs while the real provider uses hexadecimal IDs.Remove the virtual mocks and use the actual offline chain and asset configuration. All three collateral-policy assertions remain intact. Application code is unchanged.
Validation: all 53 frontend suites / 631 tests pass; typechecking, lint and formatting pass. A controlled change returning legacy collateral as active collateral fails two of the three policy tests, confirming the protection remains effective. Internal review found no issues. The original fixture passed locally, so the exact hosted resolution timing has not been reproduced; hosted matrix validation is required.