Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2546
Editing a post a second time from a timeline or profile list opened the editor with the text from before the first edit, so saving again lost that edit.
The row text is read from
StatusDataController, which is updated when a post is edited, but the Edit action used the status stored in the row view model, which is not. The data controller now keeps the latest status and the Edit action uses it.ReblogStatus.asStatusis the existing conversion moved out ofStatus.reblogAsAsStatus, with no behaviour change.Tested on iPhone 17 Pro simulator, iOS 27.0: edit a post from the profile list, save, open Edit again from the same row. The editor now shows the saved text. Editing from the post detail screen is unchanged.