Skip to content

Close the share sheet properly when no account is signed in - #2544

Open
meet4731 wants to merge 1 commit into
Dimillian:mainfrom
meet4731:fix/2543-share-sheet-signed-out
Open

meet4731 wants to merge 1 commit into
Dimillian:mainfrom
meet4731:fix/2543-share-sheet-signed-out

Conversation

@meet4731

Copy link
Copy Markdown
Contributor

Sharing to Ice Cubes with no account signed in leaves an empty New Post sheet on screen, and the X does not close it. This is #2543.

When the client is not authenticated the editor posts shareSheetClose from onAppear, while the sheet is still being presented. Completing the request at that point drops the extension context but the sheet stays up. After that extensionContext is nil, so the X cannot close it either.

ShareViewController now waits until viewDidAppear before completing the request. A close that arrives earlier is kept and done once the sheet has appeared.

Tested on simulators. Signed out on iPhone 17 Pro (iOS 26.0): the sheet now closes by itself. Signed in on iPhone SE (iOS 27.0): the sheet opens as before and the X closes it.

A signed out share now just closes. I can add a sign in message instead if you would prefer that.

Fixes #2543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Close button on the share sheet's New Post view does nothing

1 participant