Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Open in Ice Cubes action in the share sheet does nothing, as reported in #2520. The extension crashes as soon as it starts.
Since #2422 the extension target uses main actor isolation by default, so ActionRequestHandler.init() is main actor isolated. The system creates the handler on a background queue, and the executor check traps. The crash report shows _checkExpectedExecutor in ActionRequestHandler.init() on com.apple.extension.global-state-queue.
Marking the class nonisolated fixes it. Tested on an iPad (A16) simulator on iOS 26.5: before the change the sheet closes and Safari stays where it is, after the change the app opens on the shared profile.
Fixes #2520