Repository navigation
Conversation
- Add missing Japanese translations - Replace English placeholder values in the Japanese locale - Remove unused plural "one" variants from Japanese
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fills in missing Japanese (
ja) translations and replaces English placeholder values inIceCubesApp/Resources/Localization/Localizable.xcstrings. After this change, every key in the catalog has a Japanese entry (628 → 741 of 741 keys).Only the Japanese localization is touched. No other locales, keys, or source files are changed.
Why it's needed
Several keys had the English value copied into the Japanese locale and marked as
translated(e.g.settings.tabs.*,list.*,notifications.menu-title.quote*). Because they were markedtranslated, they didn't show up in Xcode's "untranslated" filter or in the SwiftPolyglot check, and Japanese users saw English text in those places. Many newer keys (App Intents / Shortcuts, notification filtering, collections, toasts) also had no Japanese entry at all.What changed
jaentryjavalue was the English source markedtranslated(e.g.settings.tabs.*,list.*,notifications.content-filter.*,notifications.menu-title.quote*,account.blocked,account.muted)settings.account.cached-posts-%@(ポスト → 投稿 for consistency),trending-tag-people-talking %lld(was English)plural.onevariants fromja. Japanese only has theotherplural category in CLDR, sooneis never used at runtime. The displayedothervalues are unchanged.Translation decisions
accessibility.editor.privacy.label), "Post visibility" → 投稿の公開範囲 (as instatus.editor.visibility), "ALT" → 注釈, "Mention" → 返信.PostIntent,PostImageIntent): 〜を作成するInlinePostIntent,InlinePostImageIntent): 〜を投稿するPublic,Quiet Public,Followers Only,Private) use the same Japanese wording as the in-app visibility picker (status.visibility.*), since they refer to the same visibility levels.Things reviewers should be aware of
needs_reviewstate.Linked Issues
None.
Type of Change
Checklist:
%lld,%@,%#@…@,%arg) in every changed Japanese string match the English source.jaand no key or metadata was changed (diffed againstmain).translatedstate.Screenshots (if applicable)
Not applicable. This Pull Request only changes translation strings.
Additional Notes
None.