Repository navigation
Conversation
- Set `defaultProps.color` to `info` for both in `DiamondDSTheme` - Default the Storybook args to `info`
# Conflicts: # changelog.md
- Restore the progress main roles test to its original assertions - Add a separate test for the info default on linear and circular progress
VictoriaBeilsten-Edmands
previously approved these changes
Nov 10, 2026
VictoriaBeilsten-Edmands
previously approved these changes
Nov 13, 2026
VictoriaBeilsten-Edmands
left a comment
Collaborator
There was a problem hiding this comment.
Changes look fine. Would you fix the changelog merge conflict, please?
zoharma
requested review from
VictoriaBeilsten-Edmands
and removed request for
douglaswinter
November 13, 2026 10:36
VictoriaBeilsten-Edmands
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinearProgressandCircularProgressnow default tocolor="info"inDiamondDSTheme, in line with the design system docs. It applies only when nocoloris passed. Setcolor="primary"to keep the previous look.colorargs default toinfo.