Skip to content

Default LinearProgress and CircularProgress to **info** - #351

Open
zoharma wants to merge 5 commits into
mainfrom
zma/linear-progress-info
Open

zoharma wants to merge 5 commits into
mainfrom
zma/linear-progress-info

Conversation

@zoharma

@zoharma zoharma commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • Default colour: LinearProgress and CircularProgress now default to color="info" in DiamondDSTheme, in line with the design system docs. It applies only when no color is passed. Set color="primary" to keep the previous look.
  • Storybook: the story color args default to info.
Current New
image image
image image

- Set `defaultProps.color` to `info` for both in `DiamondDSTheme`
- Default the Storybook args to `info`
@zoharma
zoharma requested a review from a team October 9, 2026 16:20
@zoharma zoharma added this to the 0.9.0 milestone Oct 9, 2026
Comment thread src/themes/DiamondDSTheme.test.ts Resolved
@zoharma zoharma added the priority/p3-low Nice to have, could do label Oct 27, 2026

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Restore the progress main roles test to its original assertions
- Add a separate test for the info default on linear and circular progress

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Would you fix the changelog merge conflict, please?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p3-low Nice to have, could do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants