Skip to content

refactor: store device child tree in BlueapiDevice - #1766

Open
shree-iyengar-dls wants to merge 4 commits into
mainfrom
1726_store_device_child_tree_in_blueapidevice
Open

shree-iyengar-dls wants to merge 4 commits into
mainfrom
1726_store_device_child_tree_in_blueapidevice

Conversation

@shree-iyengar-dls

@shree-iyengar-dls shree-iyengar-dls commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1726

Not sure if this should be a feat but have put refactor in PR title for now

Summary of changes:

  • Added a DeviceTree dataclass and corresponding tree field in BlueapiDevice
  • _add_device function how creates the tree node and returns a BlueapiDevice (or None) instead of a bool
  • _register_children fills in each parent's tree from the children

I got a little bit lost when making the changes in _register_children so not sure if what I've done is fully correct, lmk if it needs changing

After this, there will be a change to make the device tree viewable on the client side

@shree-iyengar-dls
shree-iyengar-dls requested a review from a team as a code owner November 16, 2026 10:33
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.32%. Comparing base (5424f13) to head (d1c70d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1766   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files          50       50           
  Lines        3831     3839    +8     
=======================================
+ Hits         3690     3698    +8     
  Misses        141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store the device child tree in the BlueapiDevice

1 participant