Repository navigation
docs(workflow): Treat in-session requests on an open PR as feedback to record - #58
Open
DetweilerRyan wants to merge 1 commit into
Open
DetweilerRyan wants to merge 1 commit into
DetweilerRyan wants to merge 1 commit into
Conversation
…back AGENTS.md gains a boundary, loaded by every session, against acting on the owner's feedback on an open pull request before recording it there, and says that any request in the session that changes an open pull request is feedback, approvals and choices between offered options included. The workflow index's trigger for revising work and the procedure's opening say the same, and the sidecar records the case on #57 that prompted it, the second after #47. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DetweilerRyan
marked this pull request as ready for review
November 22, 2026 03:58
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure a fresh session treats the owner's requests in the session as feedback on an open pull request, and records them there before acting.
Requested in a Claude Code session, 2026-11-22, after the miss on #57 (recorded there):
What to look at
AGENTS.md. It's the only file every session loads, and the engineering index allows a boundary there when you ask for it to be loaded in every session. It points to Revising work rather than restating the steps.revising-work.md's opening and in the index's "Read when" row: any request in the session that changes an open pull request, draft or ready, including an approval, a choice between offered options, or asking for something to be added, moved or renamed.Decisions made
AGENTS.mdboundary and the index row name it, so a session recognises the trigger without opening the procedure first. Not taken: only the one sentence inrevising-work.mdthat was first offered. That fixes the definition, but a fresh session reads it only once it already knows to open the procedure, which is the step that was missed.revising-work.meta.md: the second miss, after Add workflow procedures and use a worktree per piece of work #47, and why the guard went intoAGENTS.md.For the owner to confirm
Nothing.
Changed test expectations
Nothing.
Verification
lint,format:check,typecheck,npm testandnpm run build; all exit 0.test:e2eisn't onmainyet; it arrives with test(e2e): Add Gherkin acceptance tests with playwright-bdd and Screenplay actors #57.Links
Follows #57. Relates to #47, where
revising-work.mdcame from.🤖 Generated with Claude Code