Repository navigation
Record why CI keeps its steps: #52's speed-ups measured, not taken - #53
Merged
Merged
Conversation
scripts/ci-checks.sh runs the five definition-of-done checks at the same time in one step, with Types before Production build, and prints each check's output in a group named for it, with an error annotation for each failure. setup-node no longer restores the npm cache, and npm ci skips the audit and funding output. ci.md says where a failed check now appears, and ci.meta.md has the local measurements and the options not taken. Closes #52 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Feedback given in a Claude Code session, 2026-11-21, after three CI runs of 200c39c (attempts 1–3 of run 44955290713: 64, 58 and 60 s, against 62, 62 and 58 s before) showed no measurable saving:
|
Three CI runs of 200c39c took 64, 58 and 60 s, against 62, 62 and 58 s before. On the runner, tests and build slow each other enough that running the checks together saves little, and run-to-run variation in the image pull and npm ci swamps the cache and audit changes. This restores ci.yml and ci.md, removes scripts/ci-checks.sh, and records the measurements in ci.meta.md as tried and not taken. Closes #52 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Answering the feedback above: done in 8b5f28b.
|
DetweilerRyan
marked this pull request as ready for review
November 21, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records in
ci.meta.mdthat #52's three CI speed-ups were tried and not taken, with the measurements, and leavesci.ymlandci.mdas they are onmain. The net diff isci.meta.mdonly.What to look at
ci.meta.md, under "Tried in Speed up CI: run the checks together, drop the npm cache, skip the audit #52, not taken". Three runs with all three changes took 64, 58 and 60 s, against 62, 62 and 58 s before. On the runner, tests and build slow each other enough that running them together saves little. Run-to-run variation in the image pull (7 s) andnpm ci(5 s) is larger than the cache and audit changes could save.tscchecks would depend on timing.Decisions made
main, so the commit the sidecar cites stays reachable. The alternative was a single rewritten commit, which would leave that reference pointing at nothing.Closes #52. The issue is settled by recording why its changes weren't taken. Remove the line if you'd rather keep Speed up CI: run the checks together, drop the npm cache, skip the audit #52 open for the image pull, which is the largest step.For the owner to confirm
Nothing.
Changed test expectations
Nothing.
Verification
npm run lint,npm run format:check,npm run typecheck,npm testandnpm run buildeach exit 0 locally on 8b5f28b.ci.meta.md.ci.ymlkeeps one step per check.ci.yml, since the net diff doesn't change it.Links
Closes #52. The owner's feedback is in this comment.
🤖 Generated with Claude Code