Skip to content

Record why CI keeps its steps: #52's speed-ups measured, not taken - #53

Merged
DetweilerRyan merged 2 commits into
mainfrom
ci/parallel-checks
Nov 21, 2026
Merged

DetweilerRyan merged 2 commits into
mainfrom
ci/parallel-checks

Conversation

@DetweilerRyan

@DetweilerRyan DetweilerRyan commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Records in ci.meta.md that #52's three CI speed-ups were tried and not taken, with the measurements, and leaves ci.yml and ci.md as they are on main. The net diff is ci.meta.md only.

What to look at

  • The CI measurements in ci.meta.md, under "Tried in Speed up CI: run the checks together, drop the npm cache, skip the audit #52, not taken". Three runs with all three changes took 64, 58 and 60 s, against 62, 62 and 58 s before. On the runner, tests and build slow each other enough that running them together saves little. Run-to-run variation in the image pull (7 s) and npm ci (5 s) is larger than the cache and audit changes could save.
  • The note on Types beside Production build, in case running the checks together is tried again. 39 timed trials passed, but what tsc checks would depend on timing.

Decisions made

  • Two commits, not one. 200c39c made the three changes, and 8b5f28b reverts them and records the results. With a rebase merge both land on main, so the commit the sidecar cites stays reachable. The alternative was a single rewritten commit, which would leave that reference pointing at nothing.
  • Closes #52. The issue is settled by recording why its changes weren't taken. Remove the line if you'd rather keep Speed up CI: run the checks together, drop the npm cache, skip the audit #52 open for the image pull, which is the largest step.

For the owner to confirm

Nothing.

Changed test expectations

Nothing.

Verification

Links

Closes #52. The owner's feedback is in this comment.

🤖 Generated with Claude Code

scripts/ci-checks.sh runs the five definition-of-done checks at the same
time in one step, with Types before Production build, and prints each
check's output in a group named for it, with an error annotation for each
failure. setup-node no longer restores the npm cache, and npm ci skips the
audit and funding output. ci.md says where a failed check now appears, and
ci.meta.md has the local measurements and the options not taken.

Closes #52

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
split Ready Ready Preview Nov 21, 2026 10:20pm UTC

@DetweilerRyan

Copy link
Copy Markdown
Owner Author

Feedback given in a Claude Code session, 2026-11-21, after three CI runs of 200c39c (attempts 1–3 of run 44955290713: 64, 58 and 60 s, against 62, 62 and 58 s before) showed no measurable saving:

shrink it to the record, maybe the app to too small to really be able to squeeze out any gains right now.

Three CI runs of 200c39c took 64, 58 and 60 s, against 62, 62 and 58 s
before. On the runner, tests and build slow each other enough that running
the checks together saves little, and run-to-run variation in the image
pull and npm ci swamps the cache and audit changes. This restores ci.yml
and ci.md, removes scripts/ci-checks.sh, and records the measurements in
ci.meta.md as tried and not taken.

Closes #52

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DetweilerRyan DetweilerRyan changed the title Run the CI checks together, and drop the npm cache and audit Record why CI keeps its steps: #52's speed-ups measured, not taken Nov 21, 2026
@DetweilerRyan

Copy link
Copy Markdown
Owner Author

Answering the feedback above: done in 8b5f28b.

  • ci.yml and ci.md are back to their main versions, and scripts/ci-checks.sh is removed.
  • ci.meta.md records all three changes as tried and not taken, under "Tried in Speed up CI: run the checks together, drop the npm cache, skip the audit #52, not taken", with the CI and local measurements.
  • The self-review found one claim that went too far: "Types beside Production build is safe". It now says "would almost always work".
  • The description is updated to match.

@DetweilerRyan
DetweilerRyan marked this pull request as ready for review November 21, 2026 22:21
@DetweilerRyan
DetweilerRyan merged commit 07547f7 into main Nov 21, 2026
3 checks passed
@DetweilerRyan
DetweilerRyan deleted the ci/parallel-checks branch November 21, 2026 22:27
DetweilerRyan pushed a commit that referenced this pull request Nov 21, 2026
ci.meta.md cited 200c39c, the hash the commit had on #53's branch. The rebase merge rewrote it to 7f9f40e, so the old hash isn't on main. It now cites 7f9f40e and keeps 200c39c as the commit the CI runs tested.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed up CI: run the checks together, drop the npm cache, skip the audit

1 participant