Repository navigation
Install VS Code extensions in the dev container - #51
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DetweilerRyan
marked this pull request as ready for review
November 21, 2026 20:57
Adds Git Worktree Manager, Oxc, Vitest and GitHub Pull Requests under customizations.vscode.extensions, and points the kit README at the list. Closes #49 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dev container installs its extensions from marketplace.visualstudio.com and each publisher's subdomain of gallery.vsassets.io and gallerycdn.vsassets.io. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DetweilerRyan
force-pushed
the
chore/devcontainer-extensions
branch
from
November 21, 2026 21:13
545a13c to
94dbf65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds four VS Code extensions to the dev container, as #49 asks, and allows the VS Code Marketplace in the kit's network policy so the container can install them.
What to look at
.devcontainer/devcontainer.json: the newcustomizations.vscode.extensionslist, with a comment on each entry saying what it is for..sbx-kits/splitsmart/splitsmart.yaml: three new runtime allow entries,marketplace.visualstudio.com:443,'*.gallery.vsassets.io:443'and'*.gallerycdn.vsassets.io:443'..sbx-kits/splitsmart/README.md: a pointer to the extension list, and the new hosts in "Network and credentials".Decisions made
oxc.gallerycdn.vsassets.io; I read those hosts from the gallery API's asset URLs. The kit spec says*.example.commatches exactly one label, which covers these hosts. Alternative: list each publisher's two hosts. That is narrower, but adding an extension would also mean editing the policy, and the two lists would drift.editor.defaultFormatterand format-on-save aren't set incustomizations.vscode.settings. Alternative: set oxfmt as the default formatter in the container. That changes how saving behaves for everyone, so I left it for a separate change if you want it.chore/, because no existing branch kind fits a dev-environment change.For the owner to confirm
Nothing. You approved adding the Marketplace hosts to the policy in the session.
Changed test expectations
Nothing.
Verification
npm run lint,npm run format:check,npm run typecheck,npm testandnpm run buildeach exited 0 in the worktree after both commits.splitsmart.yamlparses with PyYAML. The allow list has nine plain strings, with the wildcard entries quoted.sbxand VS Code with Dev Containers, which this session doesn't have.Links
Closes #49
🤖 Generated with Claude Code