Repository navigation
Conversation
1 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16410.
When importing an Nmap XML scan report where one or more hosts do not have a
<hostnames>element (e.g. scanning an IP address directly with-nor where reverse DNS lookup is unavailable/skipped),dojo/tools/nmap/parser.pycrashed with:This occurred because
host.find("hostnames")was iterated over unconditionally, returningNonewhen the element is absent.Changes
Nonecheck before iterating overhost.find("hostnames")indojo/tools/nmap/parser.py.address[@addrtype='ipv6']and generic address attributes without throwingAttributeError.unittests/scans/nmap/issue16410.xmland automated unit testtest_parse_issue16410inunittests/tools/test_nmap_parser.py.Test results
TestNmapParser.test_parse_issue16410, verifying that Nmap scans without hostname elements import cleanly into findings with correct endpoints and port numbers.Checklist
dev.devbranch.