Repository navigation
fix(install): Install a C compiler for camera_helper - #633
Open
Tekunalogy wants to merge 1 commit into
Open
Tekunalogy wants to merge 1 commit into
Tekunalogy wants to merge 1 commit into
Conversation
The backend compiles camera_helper.so when it starts, but install_requirements.sh didn't install a compiler, so the service crash-looped on machines without cc. The loader also ignored the build's exit code, so the log only showed a missing .so error. Install build-essential during setup, and raise a clear error when the build fails. Closes #632
|
Preview build: curl -s https://raw.githubusercontent.com/DeepWaterExploration/dweOS/main/install.sh | sudo bash -s preview-pr-633Rebuilt on every push. Closing this pull request deletes the preview. |
Member
|
Has this ever occurred? The c compiler should be installed in camera_helper_loader should be replaced with standard ioctls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend compiles
camera_helper.sowhen it starts, butinstall_requirements.shdidn't install a compiler. On machines withoutcc,dwe_os_2.servicecrash-looped until systemd stopped restarting it. The loader also ignored the build's exit code, so the log showed a missing.soerror instead of the missing compiler.install_requirements.shnow installsbuild-essential(the same package the Docker image uses). It also brings the C and Linux headers thatcamera_helper.cincludes.camera_helper_loader.pynow checks the build's exit code and raises an error saying a C compiler is required, with the install command.Fixes #632
Type of change
Testing
ccoff thePATH: it now raisesRuntimeError: Failed to build camera_helper.so. A C compiler is required, install one with: sudo apt-get install -y build-essential.🤖 Generated with Claude Code